-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for show binary log status statement #638
Adds support for show binary log status statement #638
Conversation
6615877
to
71c2691
Compare
Feature asked on #635 (comment) |
@Andersson007 @laurent-indermuehle I tried to implement an integration test checking the executed query, but it don't works, seems that I think the implemented integration tests are sufficiently to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dennisurtubia LGTM, thanks for the contribution?
@laurent-indermuehle please take a look
Hi @dennisurtubia, If we're here can we also extend for MariaDB >= 10.5.2 with:
Ref.: SHOW BINLOG STATUS Regards! |
ae2a77d
to
b8c7eca
Compare
b8c7eca
to
351e031
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #638 +/- ##
===========================================
+ Coverage 24.40% 71.07% +46.67%
===========================================
Files 28 15 -13
Lines 2639 2465 -174
Branches 661 635 -26
===========================================
+ Hits 644 1752 +1108
+ Misses 1935 493 -1442
- Partials 60 220 +160
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eRadical great feedback, approved the PR again, thanks! waiting for @laurent-indermuehle 's feedback
Hey, @eRadical thank you for your suggestion! Done. |
The code starts to be really beautiful! Thanks for your contributions @eRadical and @dennisurtubia! |
4761034
into
ansible-collections:main
@dennisurtubia thanks a lot for the improvement! |
SUMMARY
Adds support for show binary log status statement.
ISSUE TYPE
COMPONENT NAME
mysql_replication
ADDITIONAL INFORMATION
SHOW MASTER STATUS
was replaced bySHOW BINARY LOG STATUS
. Doc